Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Update: Add No Bucket Check #16496

Merged
merged 3 commits into from
May 29, 2024

Resolve Mark-H's nitpick

376734c
Select commit
Loading
Failed to load commit list.
Merged

S3 Update: Add No Bucket Check #16496

Resolve Mark-H's nitpick
376734c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2024 in 1s

21.57% (-0.12%) compared to 73bfd27

View this Pull Request on Codecov

21.57% (-0.12%) compared to 73bfd27

Details

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 21.57%. Comparing base (73bfd27) to head (376734c).
Report is 106 commits behind head on 3.x.

Files Patch % Lines
core/src/Revolution/Sources/modS3MediaSource.php 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16496      +/-   ##
============================================
- Coverage     21.68%   21.57%   -0.12%     
- Complexity    10496    10567      +71     
============================================
  Files           561      561              
  Lines         31703    31949     +246     
============================================
+ Hits           6875     6892      +17     
- Misses        24828    25057     +229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.