-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix saving time for date TVs created in MODX 2.x #16505
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16505 +/- ##
=========================================
Coverage 21.68% 21.68%
- Complexity 10496 10498 +2
=========================================
Files 561 561
Lines 31703 31703
=========================================
Hits 6875 6875
Misses 24828 24828 ☔ View full report in Codecov by Sentry. |
Maybe it is better to prepare an upgrade script that changes the value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either this approach and/or the the migration script to update values.
I am also fine with that solution. |
### What does it do? Fixes the code in the "Resource/Create" and "Resource/Update" processors (that was added in #16398) to also work for date TVs that were created in MODX 2.x. ### Why is it needed? In MODX 2.x, the input property **"hideTime"** of a Date-TV is stored as the value "false" (or "true") -> `s:8:"hideTime";s:5:"false";` In MODX 3, the same property is stored as the value "0" (or "1") -> `s:8:"hideTime";s:1:"0";` In MODX installations, that were updated from MODX 2.x to MODX 3, the time part of the date-TV-value always gets deleted. ### How to test - Create a TV of type "date". - Change the value of "hideTime" from `s:1:"0";` to `s:5:"false";` in the column "input_properties". - Make sure, that the time part of the TV value still gets saved correctly. ### Related topic in the MODX forum https://community.modx.com/t/date-tv-time-wont-save/7335
What does it do?
Fixes the code in the "Resource/Create" and "Resource/Update" processors (that was added in #16398) to also work for date TVs that were created in MODX 2.x.
Why is it needed?
In MODX 2.x, the input property "hideTime" of a Date-TV is stored as the value "false" (or "true") ->
s:8:"hideTime";s:5:"false";
In MODX 3, the same property is stored as the value "0" (or "1") ->
s:8:"hideTime";s:1:"0";
In MODX installations, that were updated from MODX 2.x to MODX 3, the time part of the date-TV-value always gets deleted.
How to test
s:1:"0";
tos:5:"false";
in the column "input_properties".Related topic in the MODX forum
https://community.modx.com/t/date-tv-time-wont-save/7335