-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grouping grid sorting - ACL grids #16529
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16529 +/- ##
============================================
- Coverage 21.57% 21.52% -0.06%
- Complexity 10566 10603 +37
============================================
Files 561 561
Lines 31940 32030 +90
============================================
+ Hits 6892 6895 +3
- Misses 25048 25135 +87 ☔ View full report in Codecov by Sentry. |
331bce5
to
7e12a9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for the updates, I'd say this is good to go now
Remove stale lines brought in during rebase
Formatting, var naming, and other stylistic changes only; no functional changes.
Create new method in base and child UG GetList to improve code structure, as suggested in PR comment. Includes a couple small post-rebase adjustments as well.
3620025
to
297f240
Compare
What does it do?
Adds new grouping logic to ACL GetList processors and config props in the corresponding Ext grid classes.
Why is it needed?
Aside from the Settings grid,* other grouping grids (such as the ACL ones) neither group properly, nor sort within groups properly.
How to test
Related issue(s)/PR(s)
No related issue.