Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grouping grid sorting - ACL grids #16529

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Feb 20, 2024

What does it do?

Adds new grouping logic to ACL GetList processors and config props in the corresponding Ext grid classes.

Why is it needed?

Aside from the Settings grid,* other grouping grids (such as the ACL ones) neither group properly, nor sort within groups properly.

How to test

  1. Rebuild may be necessary and compress_js must be off.
  2. Create a variety of ACL entries so there are at least a few main items to group (this is the Minimum Role, which is what all ACLs are grouped by as a default [can be changed in the column menu]), and a few entries within those groups (meaning you'll need multiple contexts, namespaces, resource groups, media sources, and element categories created ahead of time to assign these roles to).
  3. Verify that items are grouped as expected.
  4. Verify that sorting on each column works as expected.

Related issue(s)/PR(s)

No related issue.

  • The settings grid does not group correctly if the grouping field is changed. That will be addressed in a different PR.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 115 lines in your changes are missing coverage. Please review.

Comparison is base (f197da7) 21.57% compared to head (331bce5) 21.52%.

Files Patch % Lines
...urity/Access/UserGroup/AccessNamespace/GetList.php 0.00% 22 Missing ⚠️
...ors/Security/Access/UserGroup/Category/GetList.php 0.00% 22 Missing ⚠️
...ecurity/Access/UserGroup/ResourceGroup/GetList.php 0.00% 22 Missing ⚠️
...ssors/Security/Access/UserGroup/Source/GetList.php 0.00% 22 Missing ⚠️
...sors/Security/Access/UserGroup/Context/GetList.php 0.00% 18 Missing ⚠️
...c/Revolution/Processors/Model/GetListProcessor.php 25.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16529      +/-   ##
============================================
- Coverage     21.57%   21.52%   -0.06%     
- Complexity    10566    10603      +37     
============================================
  Files           561      561              
  Lines         31940    32030      +90     
============================================
+ Hits           6892     6895       +3     
- Misses        25048    25135      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opengeek opengeek added this to the v3.1.0 milestone May 31, 2024
@smg6511 smg6511 force-pushed the 3.x-fix-grouping-grid-sorting branch from 331bce5 to 7e12a9f Compare August 20, 2024 15:10
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Aug 21, 2024
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the updates, I'd say this is good to go now

Jim Graham and others added 5 commits August 29, 2024 13:51
Remove stale lines brought in during rebase
Formatting, var naming,  and other stylistic changes only; no functional changes.
Create new method in base and child UG GetList to improve code structure, as suggested in PR comment. Includes a couple small post-rebase adjustments as well.
@opengeek opengeek force-pushed the 3.x-fix-grouping-grid-sorting branch from 3620025 to 297f240 Compare August 29, 2024 19:52
@opengeek opengeek merged commit 23d8965 into modxcms:3.x Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants