Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to render multi-select listbox TV values by selection order #16561

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Apr 19, 2024

What does it do?

Adds a new input option for this TV type to control the sorting of saved values when rendered to a Resource.

Why is it needed?

A community member requested this functionality be brought back, pointing to possible use cases where preservation of the order of selections made is desirable.

How to test

Create a Listbox (Multiple-Select) TV and experiment with changing the TV behavior via the new Preserve Entry Order option and verify that when this option is set to “Yes,” randomly selected options are shown in the order selected after saving and reloading. Conversely, verify the current default behavior remains intact (i.e., saved values appear in the same order defined by the list itself, no matter the order in which they were selected).

Related issue(s)/PR(s)

Resolves #16495.

Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce addition, works as described

@opengeek opengeek added this to the v3.1.0 milestone May 31, 2024
@jaygilmore
Copy link
Member

I've confirmed this works as described. 👍🏻

@jaygilmore jaygilmore self-requested a review May 31, 2024 18:46
@smg6511 smg6511 added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Jun 17, 2024
@opengeek opengeek changed the title Listbox (multiple) TV: Re-introduce rendering values by selection order Restore ability to render multi-select listbox TV values by selection order Jun 18, 2024
@opengeek opengeek merged commit eba69d0 into modxcms:3.x Jun 18, 2024
5 checks passed
@smg6511 smg6511 deleted the 3.x-issue-16495 branch August 27, 2024 16:11
opengeek pushed a commit that referenced this pull request Nov 6, 2024
…#16640)

### What does it do?
Back ports fixes already made and merged into 3.x. See the referenced
PRs below for more info.

### Related issue(s)/PR(s)
Alternate to PR #16241; includes back ports of #16242 and #16561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MODX 3.0.4-pl - Listbox Multiselect
5 participants