Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: make tabs focusable #16614

Closed
wants to merge 1 commit into from
Closed

A11y: make tabs focusable #16614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions _build/templates/default/sass/_a11y.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
.ext-webkit {
// #modx-header {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

* {

&:focus-visible {
outline: auto !important;
outline-offset: .1em;

&.x-form-focus {
outline: none !important;
}
}
}
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code

}
10 changes: 9 additions & 1 deletion manager/assets/modext/widgets/core/modx.tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,15 @@ MODx.Tabs = function(config = {}) {
border: false,
autoScroll: true,
autoHeight: true,
cls: 'modx-tabs'
cls: 'modx-tabs',
itemTpl: new Ext.XTemplate(
'<li class="{cls}" id="{id}">',
'<a class="x-tab-strip-close"></a>',
'<a href="#">',
'<span class="x-tab-strip-text">{text}</span>',
'</a>',
'</li>'
)
});
MODx.Tabs.superclass.constructor.call(this, config);
this.config = config;
Expand Down