Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc CHANGES log for future beta release #1616 #1715

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

RogerHaase
Copy link
Member

No description provided.

@UlrichB22
Copy link
Collaborator

A few small suggestions on capitalization or typos:

20c20
< * generate readthedocs content using python 3.10
---
> * generate readthedocs content using Python 3.10
29c29
< * add language auto-detect to user peraonal settings
---
> * add language auto-detect to user personal settings
33c33
< * Fix CI workflow to test with all supported python versions, run py39 with ubuntu 22.04
---
> * Fix CI workflow to test with all supported python versions, run py39 with Ubuntu 22.04
38c38
< * itemlinks beginning with + were incorrectly given non-existant class (+meta/Home)
---
> * itemlinks beginning with + were incorrectly given non-existent class (+meta/Home)
40c40
< * add validity check if user changes name/alias/display-name in UserSettings>Presonal
---
> * add validity check if user changes name/alias/display-name in UserSettings>Personal

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks I found.

Ping me if you need help with the release (can't promise to do testing / development though).

* generate readthedocs content using Python 3.10
* remove use of obsolete setuptools
* change use of whoosh lru cache to lfu cache
* update Flask and Werkzeug to >3.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, guess >= 3.0.0?

* mass source code changes using pyupgrade to upgrade syntax to 3.9
* removed unused imports
* create SECURITY.md
* generate readthedocs content using Python 3.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my projects I now tend to only include stuff that is somehow "interesting" for users of the software or package maintainers and try to leave away minor details (one person is writing this, but potentially many people are reading this - saves them time).

* fix maint-validate-metadata to skip userprofiles backend
* Add REV_NUMBER in sort for history view replacing mtime
* Fix CI workflow to test with all supported python versions, run py39 with Ubuntu 22.04
* add support for SQLAlchemy 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= 2.0?

* add validity check if user changes name/alias/display-name in UserSettings>Personal
* add test to prove icons from CSS URLs is a subset of files in icon dir

Version 2.0.0alpha 2024-03-27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git tag is 2.0.0a1.


Please note: It is recommended that existing wiki's be upgraded to the
latest moin 1.9.x release before converting to Moin 2. However, this may
not be a necessary step as the 1.9.x file structure has not changed recently.

Version 2.0.0alpha
------------------
Version 2.0.0beta 2024-??-??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the git tag would be 2.0.0b1?

@@ -37,6 +72,9 @@ Missing features from 1.9.x
* SVG editor
* LDAP may have missing dependencies depending upon OS flavor
* WikiDicts have limited function, does not use Babel translations
* language support limited to English, Deutsch, Portuguese (Brasil), Russian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rather "German".

Guess whoever does not understand English won't read the changelog anyway.

@UlrichB22 UlrichB22 merged commit 6dd1a78 into moinwiki:master Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants