fix(notifier) fix dropped notifications mentric (#955)

moira-alert · Nov 8, 2023 · 2e1545d · 2e1545d
1 parent ac2b022
commit 2e1545d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/notifier/notifier.go b/notifier/notifier.go
@@ -139,6 +139,7 @@ func (notifier *StandardNotifier) GetReadBatchSize() int64 {
 
 func (notifier *StandardNotifier) resend(pkg *NotificationPackage, reason string) {
 	if pkg.DontResend {
+		notifier.metrics.MarkSendersDroppedNotifications(pkg.Contact.Type)
 		return
 	}
 	notifier.metrics.SendingFailed.Mark(1)
@@ -227,7 +228,6 @@ func (notifier *StandardNotifier) runSender(sender moira.Sender, ch chan Notific
 				log.Warning().
 					Error(err).
 					Msg("Cannot send notification")
-				notifier.metrics.MarkSendersDroppedNotifications(pkg.Contact.Type)
 			}
 
 			notifier.resend(&pkg, err.Error())