Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Inform user about already registered telegram group #521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FEAT] Inform user about already registered telegram group #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
725abdf
feat(senders/telegram/handle_message.go): inform about already regist…
hv7214 Mar 28, 2020
bc11dec
refactor(senders/telegram/handle_message_test.go): removed error test…
hv7214 Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions senders/telegram/handle_message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,16 @@ func (sender *Sender) getResponseMessage(message *telebot.Message) (string, erro
return fmt.Sprintf("Okay, %s, your id is %s", strings.Trim(fmt.Sprintf("%s %s", message.Sender.FirstName, message.Sender.LastName), " "), chatID), nil
case message.Chat.Type == telebot.ChatSuperGroup || message.Chat.Type == telebot.ChatGroup:
uuid, _ := sender.DataBase.GetIDByUsername(messenger, message.Chat.Title)
err := sender.DataBase.SetUsernameID(messenger, message.Chat.Title, chatID)
if err != nil {
return "", err
}
if uuid == "" {
err := sender.DataBase.SetUsernameID(messenger, message.Chat.Title, chatID)
if err != nil {
return "", err
}
return fmt.Sprintf("Hi, all!\nI will send alerts in this group (%s).", message.Chat.Title), nil
}
if message.Text == "/start" {
return fmt.Sprintf("Hi, all!\nGroup with name (%s) is already registered.", message.Chat.Title), nil
}
return "", nil
}
return "I don't understand you :(", nil
Expand Down
13 changes: 3 additions & 10 deletions senders/telegram/handle_message_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func TestGetResponseMessage(t *testing.T) {
Type: telebot.ChatSuperGroup,
Title: "MyGroup",
},
Text: "/start",
}

Convey("GetIDByUsername returns error", func() {
Expand Down Expand Up @@ -115,18 +116,10 @@ func TestGetResponseMessage(t *testing.T) {
Convey("GetIDByUsername return uuid", func() {
dataBase.EXPECT().GetIDByUsername(messenger, message.Chat.Title).Return("123", nil)

Convey("SetUsernameID returns error", func() {
dataBase.EXPECT().SetUsernameID(messenger, message.Chat.Title, "123").Return(fmt.Errorf("error"))
response, err := sender.getResponseMessage(message)
So(err, ShouldResemble, fmt.Errorf("error"))
So(response, ShouldBeEmpty)
})

Convey("SetUsernameID returns empty error", func() {
dataBase.EXPECT().SetUsernameID(messenger, message.Chat.Title, "123").Return(nil)
Convey("Group name already exists", func() {
response, err := sender.getResponseMessage(message)
So(err, ShouldBeNil)
So(response, ShouldBeEmpty)
So(response, ShouldResemble, fmt.Sprintf("Hi, all!\nGroup with name (%s) is already registered.", message.Chat.Title))
})
})
})
Expand Down