Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getting trigger checks and merge functions #944

Merged

Conversation

almostinf
Copy link
Member

@almostinf almostinf commented Oct 24, 2023

Add getting trigger checks and merge functions

Add additional functions needed for PR #946:

  • getTriggersLastCheck function, with which I will be able to get checkData for each trigger passed in the triggerIDs array, if no checkData was found for the passed triggerID, then checkData = nil
  • generic function MergeToSorted, which takes as input 2 arrays that can be compared by Less function, then merges them into one sorted array

Divided 1 big PR into 3 parts, here are the rest:

@almostinf almostinf requested a review from a team as a code owner October 24, 2023 11:12
@almostinf almostinf changed the base branch from master to feat/add-redis-notifier-config October 24, 2023 11:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/add-redis-notifier-config@fd3429d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0bdf937 differs from pull request most recent head 5004c9a. Consider uploading reports for the commit 5004c9a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                        Coverage Diff                        @@
##             feat/add-redis-notifier-config     #944   +/-   ##
=================================================================
  Coverage                                  ?   69.06%           
=================================================================
  Files                                     ?      196           
  Lines                                     ?    11099           
  Branches                                  ?        0           
=================================================================
  Hits                                      ?     7666           
  Misses                                    ?     2986           
  Partials                                  ?      447           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@almostinf almostinf requested a review from Tetrergeru October 31, 2023 11:01
@almostinf almostinf merged commit 342211a into feat/add-redis-notifier-config Nov 13, 2023
@almostinf almostinf deleted the feat/add-getting-checkdatas-and-merge branch November 13, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants