Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert feat(notifier): fix sending unwanted notifications on muted and deleted triggers and muted metrics #962

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Tetrergeru
Copy link
Member

No description provided.

…nd deleted triggers and muted metrics (#943)"

This reverts commit ed1f263.
@Tetrergeru Tetrergeru requested a review from a team as a code owner November 13, 2023 09:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #962 (46123ca) into master (ed1f263) will decrease coverage by 0.21%.
The diff coverage is 76.78%.

❗ Current head 46123ca differs from pull request most recent head 6c8eb1b. Consider uploading reports for the commit 6c8eb1b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   69.44%   69.24%   -0.21%     
==========================================
  Files         196      196              
  Lines       11208    11047     -161     
==========================================
- Hits         7783     7649     -134     
+ Misses       2962     2946      -16     
+ Partials      463      452      -11     
Files Coverage Δ
database/redis/database.go 91.04% <100.00%> (-1.55%) ⬇️
database/redis/last_check.go 85.47% <ø> (+0.08%) ⬆️
datatypes.go 78.62% <ø> (-1.75%) ⬇️
helpers.go 89.38% <ø> (-0.10%) ⬇️
notifier/notifier.go 70.99% <100.00%> (ø)
notifier/scheduler.go 84.25% <ø> (-0.29%) ⬇️
cmd/api/main.go 0.00% <0.00%> (ø)
cmd/cli/main.go 0.00% <0.00%> (ø)
database/redis/notification.go 77.56% <78.43%> (+1.14%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Tetrergeru Tetrergeru merged commit 5fc5a29 into master Nov 13, 2023
6 checks passed
@Tetrergeru Tetrergeru deleted the revert/fix-sending-unwanted-notifications branch November 13, 2023 11:29
Copy link

Build and push Docker images with tag: 2023-11-13.5fc5a29

almostinf added a commit that referenced this pull request Nov 14, 2023
… and deleted triggers and muted metrics (#962)"

This reverts commit 5fc5a29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants