Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Token component to Storybook and one more state of this component #356

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add Token component to Storybook and one more state of this component #356

wants to merge 2 commits into from

Conversation

bsgribtmfu
Copy link

No description provided.

@sashasushko sashasushko self-requested a review December 20, 2021 15:27
@sashasushko
Copy link

@bsgribtmfu не в том порядке начал.

Сперва нужно:

  • создать сториз-файл для компонента Token по аналогии с другими сторизами
  • описать в сториз текущие вариации компонента
  • запустить скриншот тесты (creevey), чтобы создать бэкап-скриншоты

И уже после добавлять новое состояние.

@sashasushko
Copy link

Давай так поступим:

  • откати коммит в ветке git reset HEAD~1 --soft
  • оставь в коммите ту часть, которая нужна для выполнение пунктов, остальное застэшь git stash
  • после добей пункты, закоммить и присылай на ревью

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashasushko sashasushko Awaiting requested review from sashasushko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsgribtmfu @sashasushko