Fix #21

moira/api/resources/redis.py

@@ -3,6 +3,7 @@
 from twisted.web.resource import Resource
 
 from moira.api.request import check_trigger, check_json
+from moira.checker import state
 
 
 class RedisResouce(Resource):
@@ -33,7 +34,15 @@ def save_trigger(self, request, trigger_id, message):
 
         if last_check:
             last_check['metrics'] = {}
-            yield self.db.setTriggerLastCheck(trigger_id, last_check)
+        else:
+            last_check = {
+                "metrics": {},
+                "state": state.NODATA,
+                "score": 0
+            }
+            print last_check
+
+        yield self.db.setTriggerLastCheck(trigger_id, last_check)
 
         yield self.db.delTriggerCheckLock(trigger_id)
 

moira/api/resources/trigger.py

@@ -115,6 +115,7 @@ def render_PUT(self, request):
         trigger_id = str(uuid.uuid4())
         yield self.save_trigger(request, trigger_id, "trigger created")
 
+
 class Page(RedisResouce):
 
     def __init__(self, db):

moira/checker/trigger.py

@@ -30,13 +30,15 @@ def init(self, now, fromTime=None):
         self.ttl = self.struct.get("ttl")
         self.ttl_state = self.struct.get("ttl_state", state.NODATA)
         self.last_check = yield self.db.getTriggerLastCheck(self.id)
+        begin = (fromTime or now) - 3600
         if self.last_check is None:
-            begin = (fromTime or now) - 3600
             self.last_check = {
                 "metrics": {},
                 "state": state.NODATA,
                 "timestamp": begin
             }
+        if self.last_check.get("timestamp") is None:
+            self.last_check["timestamp"] = begin
         if self.last_check.get("score") is None:
             self.update_score = True
         defer.returnValue(True)

tests/functional/test_api.py

@@ -126,8 +126,8 @@ def testTriggersPaging(self):
 
         response, triggers = yield self.request('GET', 'trigger/page?p=0&size=10',
                                                 add_headers={'Cookie': ['moira_filter_tags=tag1; moira_filter_ok=true']})
-        self.assertEqual(1, len(triggers["list"]))
-        self.assertEqual(1, triggers["total"])
+        self.assertEqual(0, len(triggers["list"]))
+        self.assertEqual(0, triggers["total"])
 
         response, triggers = yield self.request('GET', 'trigger/page?p=0&size=10',
                                                 add_headers={'Cookie': ['moira_filter_tags=']})