fix: actually log the userinfo object returned by the IAM #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Userinfo object is not currently logged due to a misunderstanding of the logger api. This fixes it.
bushjames
changed the title
partiallyordered
suggested changes
Aug 18, 2021
There was a problem hiding this comment.
There are a couple of other instances of this type of usage of the logger later in the same file, perhaps change those now also?
Also, probably want to bump the version. I discovered npm version patch the other day. Run that command in the directory containing the package.json file. There's also npm version minor and npm version major.
Tangentially, this pattern with multiple arguments to the logger methods (that does not work since the logger changed to pino) might exist more widely in this code. could be a good application of codemods.
| @@ -14,7 +14,7 @@ const permit = async (userInfoURL, token, requestMethod, requestPath, log) => { | |||
| agent: selfSignedAgent, | |||
| }; | |||
| const userinfo = await fetch(userInfoURL, opts).then((res) => res.json()); | |||
| log.info('Got userinfo:', userinfo); | |||
| log.info(`Got userinfo: ${userinfo}`); | |||
There was a problem hiding this comment.
This will result in better structure in the logs (although it's less logger-agnostic).
Suggested change
| log.info(`Got userinfo: ${userinfo}`); | |
| log.child({ userInfo }).info('Got userinfo'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Userinfo object is not currently logged due to a misunderstanding of the logger api. This fixes it.
Example of current log output showing the issue:
{"level":30,"time":1629199407789,"pi[redacted]XFiucU"}},"msg":"Got userinfo:"}