-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bulk quotes callback sending wrong value patterns #230
base: main
Are you sure you want to change the base?
fix: bulk quotes callback sending wrong value patterns #230
Conversation
…to enable creating multiple bulk requests for the same bulkQuoteId
@elnyry-sam-k and @vijayg10 Guys, can we get some feedback on this PR please? Getting this to work would be really helpful to test bulk quotes and transfers. |
@pedrosousabarreto , @ruirochawork - can you please address the failing CI steps while the review is happening.. That'll help push it through once the review is complete. Thanks! |
@elnyry-sam-k This pipeline is failing on most runs, and we recall that at the time you and Vijay mentioned you would check what was going on. This PR on the UI is the same: mojaloop/ml-testing-toolkit-ui#163 There are seven open PRs on this project alone, and the majority has been there since more than 3 months. @bushjames We're making it really hard to contribute, we should put some effort in making this process easier to the developers, I'm sure it is possible without compromising security and quality. |
@pedrosousabarreto please fix whatever steps you can. @vijayg10 can you please offer guidance on the dependencies and failures on the other steps, thank you! Lets get these to pass, or its likely they'll stay that way. |
we need to move things faster and I agree that we can make it easier, sure. But lets not exaggerate things here to the point of misleading; 4 of the PRs, which is greater than 50% are in DRAFT state, meaning they're not ready. So its just 3 PRs that are ready to be reviewed. Out of these 3 PRs, one was just opened today and another is in progress (the FX PR), which leads to only one PR left, this one! We need to work together towards making things more efficient and faster and easier for contribution (within constraints) but no need for falsities here.. I've asked Vijay's help with the review. |
Separately, I'll start an effort to address open PRs on the critical repos (and ones included in the releases), we need to put some intentional effort there. |
Hi @ruirochawork , sorry for the late review. I reviewed it and observed the changes are for generating callback for specific resources (bulk). Can't we do that in rule dynamically instead of hardcoding resource specific code? |
Hi @vijayg10 I think that is intentional, as this problem is only observable with bulk. I'm sure what you ask would be better in the long run, maybe that can be addressed as a future enhancement? |
@pedrosousabarreto We can use inbound scripting feature in rules to generate the callbacks whatever we want. We don't need to hardcode the resource specific functionality in TTK. I suggest to have a call and I can show you the process and lets find out if we can do the samething with scripting. If we find out that we can't use that for this usecase, then I don't have a problem with this PR. So @ruirochawork , can you arrange a call for this? |
There's a need of executing multiple requests for the same bulkQuoteId for the testability of both its ordering and logic execution.