Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulk quotes callback sending wrong value patterns #230

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ruirochawork
Copy link

There's a need of executing multiple requests for the same bulkQuoteId for the testability of both its ordering and logic execution.

  • updated mockRefs and added specific use case for bulk requeststo enable creating multiple bulk requests for the same bulkQuoteId

…to enable creating multiple bulk requests for the same bulkQuoteId
@ruirochawork ruirochawork marked this pull request as draft January 16, 2023 12:20
@ruirochawork ruirochawork marked this pull request as ready for review November 20, 2023 12:59
@pedrosousabarreto
Copy link

pedrosousabarreto commented Nov 20, 2023

@elnyry-sam-k and @vijayg10 Guys, can we get some feedback on this PR please? Getting this to work would be really helpful to test bulk quotes and transfers.

@elnyry-sam-k
Copy link
Member

@pedrosousabarreto , @ruirochawork - can you please address the failing CI steps while the review is happening..

That'll help push it through once the review is complete. Thanks!

@pedrosousabarreto
Copy link

@elnyry-sam-k This pipeline is failing on most runs, and we recall that at the time you and Vijay mentioned you would check what was going on.
We can change the PR name, but other things like for example upgrading mongoose from 7.5.3 to 8.0.1 (a major version update) sounds really dangerous, not sure why a CI/CD pipeline would enforce a major update on a dependency.
The vulnerability check is also not passing, but no dependencies where added, again, not sure if a developer making a contribution should have the burden of fixing issues like this.

image

This PR on the UI is the same: mojaloop/ml-testing-toolkit-ui#163

There are seven open PRs on this project alone, and the majority has been there since more than 3 months.

@bushjames We're making it really hard to contribute, we should put some effort in making this process easier to the developers, I'm sure it is possible without compromising security and quality.

@elnyry-sam-k
Copy link
Member

elnyry-sam-k commented Nov 21, 2023

@pedrosousabarreto please fix whatever steps you can. @vijayg10 can you please offer guidance on the dependencies and failures on the other steps, thank you!

Lets get these to pass, or its likely they'll stay that way.

@elnyry-sam-k
Copy link
Member

There are seven open PRs on this project alone, and the majority has been there since more than 3 months.

we need to move things faster and I agree that we can make it easier, sure.

But lets not exaggerate things here to the point of misleading; 4 of the PRs, which is greater than 50% are in DRAFT state, meaning they're not ready. So its just 3 PRs that are ready to be reviewed.

Out of these 3 PRs, one was just opened today and another is in progress (the FX PR), which leads to only one PR left, this one!

We need to work together towards making things more efficient and faster and easier for contribution (within constraints) but no need for falsities here.. I've asked Vijay's help with the review.

@elnyry-sam-k
Copy link
Member

Separately, I'll start an effort to address open PRs on the critical repos (and ones included in the releases), we need to put some intentional effort there.

@ruirochawork ruirochawork changed the title Feat/BulkQuotes handler now executes multiple randomly split requests fix: bulk quotes callback sending wrong value patterns Nov 23, 2023
@vijayg10
Copy link
Contributor

vijayg10 commented Dec 8, 2023

Hi @ruirochawork , sorry for the late review. I reviewed it and observed the changes are for generating callback for specific resources (bulk). Can't we do that in rule dynamically instead of hardcoding resource specific code?

@pedrosousabarreto
Copy link

Hi @vijayg10 I think that is intentional, as this problem is only observable with bulk.

I'm sure what you ask would be better in the long run, maybe that can be addressed as a future enhancement?

@vijayg10
Copy link
Contributor

@pedrosousabarreto We can use inbound scripting feature in rules to generate the callbacks whatever we want. We don't need to hardcode the resource specific functionality in TTK. I suggest to have a call and I can show you the process and lets find out if we can do the samething with scripting. If we find out that we can't use that for this usecase, then I don't have a problem with this PR. So @ruirochawork , can you arrange a call for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants