-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change version
to a Development Tag
#21
Conversation
7cddccc
to
5daf2f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we sync our fork with the latest release from flexbe also the package.json should be synced and thus the version tag should match to the latests available release. So there should not be any more warnings about a newer version. If flexbe released a new version it is valid to have a warning on the GUI even if we are using our own fork. So we always know if it would make sense to check if a new sync should be done.
In my option we should merge the package.json instead of adding a version tag that is not existing.
This would be the optimal solution but I don't think this is easily possible. We are using the ROS 1 version of FlexBE where the last If I saw this correctly we could either:
I'd go with 1, 3 or 4. |
I get the following error when changing the
|
Ah correct, I've just tested it with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I guess comparing to
mojin-robotics/flexbe_app
makes sense - I synced the versions of
package.xml
andpackage.json
- I will push a tag for
2.4.0
to our fork
I used |
ref https://github.com/4am-robotics/orga/issues/4739
This prevents the New release available! popup and since we're using already a "custom" version it fits better than the default
version
tag.