add arm64 support #22
Conversation
| mirror_uri="https://npm.taobao.org/mirrors/nwjs/$VERSION/nwjs-$VERSION-$OS-$ARCH.tar.gz" | ||
| curl -sL -o $TEMPFILE $mirror_uri | ||
| if [ "$ARCH" == "arm64" ]; then | ||
| main_uri="https://github.com/LeonardLaszlo/nw.js-armv7-binaries/releases/download/nw60-arm64_2022-01-08/nw60-arm64_2022-01-08.tar.gz" |
There was a problem hiding this comment.
It would be nice to move the URL to a "global" variable, since it probably needs to be adjusted with the version tag in line 7.
Unfortunately , using the $VERSION and $OS and variables to construct the URL doesn't seem possible, but the $ARCH variable could be used. This probably doesn't make sense if the URL gets moved to the top..
There was a problem hiding this comment.
hmm, yes. Problem is that the url for the arm version is a completely different one. So I decided to stick to a fixed version for arm but keep it as it was for the win, linux, osx releases.
There was a problem hiding this comment.
Yes, makes sense. That's why the mv command in line 47 doesn't use the variables.
There was a problem hiding this comment.
What do you think about an ARM_VERSION variable? And a wildcard (*) in line 47.
There was a problem hiding this comment.
I see your point. But I think that this will not help a lot because the download link also includes a date. Other Versions will have a completely different date in uri. Perhaps future releases of nwjs will also include linux-arm64 Versions. Then we can roll back and use the same logic for all versions.
| curl -sL -o $TEMPFILE $main_uri | ||
| tar -xzf $TEMPFILE --strip-components 1 | ||
| rm $TEMPFILE | ||
| mv docker/dist/nwjs-chrome-ffmpeg-branding/nwjs-v0.60.1-linux-arm64.tar.gz nwjs.tar.gz |
There was a problem hiding this comment.
We could only use it vor v0.60.1 but will this help here?
I have a virtual ubuntu arm running |
benmaidel
force-pushed
the
feature/arm64_support
branch
from
321dba9
to
3a5ad5e
Compare
benmaidel
force-pushed
the
feature/arm64_support
branch
from
754e7a6
to
fd7eabe
Compare
Binaries are only supplied by community and not officially released. That's why arm64 has to be handled differently.