Removal of Mercury and Numeric version schemes, refactoring #1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Numeric and Mercury version schemes. Mercury is probably not used at all, Numeric can be used due to some artifacts, but since it is not respected by Maven Resolver itself, it makes little sense to keep it.
With the two comparators removed, we can simply use the default comparator that
DefaultArtifact
provides on its own (which is also in line with Resolver implementation ofGenericVersion
).The rest is refactoring:
RuleService
fromVersionsHelper
to handle rules-related business, e.g. ignored versions;ArtifactFactory
;DefaultArtifactVersionCache
toArtifactVersionService
;PropertyVersions
: moved artifact resolution business toDefaultVersionsHelper
;