Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Mercury and Numeric version schemes, refactoring #1212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrzejj0
Copy link
Contributor

Removed Numeric and Mercury version schemes. Mercury is probably not used at all, Numeric can be used due to some artifacts, but since it is not respected by Maven Resolver itself, it makes little sense to keep it.

With the two comparators removed, we can simply use the default comparator that DefaultArtifact provides on its own (which is also in line with Resolver implementation of GenericVersion).

The rest is refactoring:

  • Simplified code, added some unit tests while doing so;
  • Extracted RuleService from VersionsHelper to handle rules-related business, e.g. ignored versions;
  • Extracted ArtifactFactory;
  • Renamed DefaultArtifactVersionCache to ArtifactVersionService;
  • PropertyVersions: moved artifact resolution business to DefaultVersionsHelper;

@slawekjaranowski
Copy link
Member

great, as it is next big change I will try to review it in next weekend
of course will be good if someone else also look at it

@andrzejj0
Copy link
Contributor Author

Please feel free to invite other reviewers. Maybe Hervé or Tamas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants