Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a map to avoid gsub on every parse pattern #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmondo
Copy link
Contributor

@jmondo jmondo commented Oct 16, 2016

Same idea as #340 except less intrusive to the developer

I borrowed from active support #underscore method for snake casing

@jmondo jmondo changed the title Use a map to avoid dynamic gsub Use a map to avoid gsub on every parse Oct 16, 2016
@jmondo jmondo changed the title Use a map to avoid gsub on every parse Use a map to avoid gsub on every parse pattern Oct 16, 2016
@davispuh
Copy link
Collaborator

I've been working on #278 (which rewrites quite a bit of logic) for some while but it's still unfinished and lately I haven't had time to continue it but I still plan on finishing it eventually and you should look at it since it doesn't need this at all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants