Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounted Asset Removal #3

Open
Gocnak opened this issue Aug 30, 2022 · 3 comments
Open

Mounted Asset Removal #3

Gocnak opened this issue Aug 30, 2022 · 3 comments

Comments

@Gocnak
Copy link
Member

Gocnak commented Aug 30, 2022

We actually have a C++ tool shipping with the game that does this: "bspfix.exe"

So ideally all we need to do is invoke it on the bsp here.

@BIRD311 BIRD311 self-assigned this Oct 13, 2022
@BIRD311 BIRD311 mentioned this issue Nov 18, 2022
@tsa96
Copy link
Member

tsa96 commented Feb 7, 2023

For clarification, we have bspfix in C++ but want to write a C# version. Rewriting the C++ exactly would require license, but the concept is simple, compare a hash of every file in the Paklump with Valve assets of corresponding file type.

We don't want to require everyone running these checks have all content downloaded, instead we'll ship a JSON file with releases.

We need:

  • Functionality mentioned above of traversing the Paklump and hash checking every file against a JSON list of hashes
  • To be able to generate hashes of every file in a VPK and write to JSON list

Both should be usable via CLI and UI. It's important we can hook the hash generation up to our internal CI, as well as perform the hash checks via command-line, maaaaaybe integrating into the backend eventually.

@tsa96
Copy link
Member

tsa96 commented Feb 7, 2023

@BIRD311 BIRD311 removed their assignment Feb 7, 2023
@BIRD311
Copy link
Member

BIRD311 commented Feb 7, 2023

Unassigned my self for now in case someone wants to pick this up. Calling bspfix on the map was implemented* but rewriting this in C# was not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants