Feat/tasks #9
Merged
Feat/tasks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
requested changes
Nov 30, 2022
Gocnak
approved these changes
Dec 13, 2022
|
Re-requested @Panzerhandschuh and @tsa96 for 👀 but looks great to me! |
Adds a system to modify and run checks on the BSP.
Task can be serialized to json.
They can report progress and result for the UI.
Tasks:
- applying stripper config changes to the bsp
- changing textures
- compression
- running external tools like bspfix
Panzerhandschuh
approved these changes
Dec 13, 2022
tsa96
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 should be fine with this. Not sure where to put paths for different system configurations. Maybe variables for the task to parse, setting environment variables, let the user change it and supply a windows and linux version ...
#2 drag and drop is obviously not implemented and there is no automatic detection of slurs but the rest should be fine with this.
I left 2 todos in. Both have something to do with UI and how the Tasks should tell the user if something is wrong or could be wrong.