Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java Platform Module System #6

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ielis
Copy link
Member

@ielis ielis commented Oct 15, 2020

Modularize the code base.

Daniel Danis added 4 commits August 26, 2020 14:51
# Conflicts:
#	pom.xml
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/classifier/IntegrationTests.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/classifier/io/DeserializerTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/classifier/prediction_transform/SimpleMutablePrediction.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/classifier/transform/prediction/SimpleLogisticRegressionTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/classifier/tree/BinaryDecisionTreeTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/reference/allele/AlleleGeneratorTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/CanonicalDonorFeatureCalculatorTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/DenseSplicingAnnotatorTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/HexamerFeatureCalculatorTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/calculators/BigWigTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/calculators/CalculatorTestBase.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/calculators/CanonicalAcceptorScorerTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/calculators/CrypticAcceptorScorerTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/calculators/CrypticDonorScorerTest.java
#	squirls-core/src/test/java/org/monarchinitiative/squirls/core/scoring/calculators/SeptamerTest.java
@ielis
Copy link
Member Author

ielis commented Oct 15, 2020

There seems to be an issue with zaxxer.hikari when introducing module-info into autoconfigure. Hikari requires provided dependency that we do not have in the system at the dependencies. Evaluate..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant