-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Synonym sync: acronym case exception - build #677
DO NOT MERGE: Synonym sync: acronym case exception - build #677
Conversation
ff606ee
to
312389b
Compare
312389b
to
14f04b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General review
Overall build LGTM!
New synonym sync outputs were ran recently before this build and are in the Google sheet. Those same outputs look good in this build.
Build stats
Build time was unusually high. About 7 hours. I haven't yet analyzed why that might be the case, though. I did notice that it seemed to be stuck on the synonym sync for Ordo for a bit, but IDK why that'd be the case. Normally the synonym sync Python scripts take about 45 seconds to complete for all sources. I might want to re-run part of / whole pipeline to sanity check performance. I wonder if my mac went to sleep at some point, though it shouldn't when it's plugged in.
@joeflack4 did you check back to see why this run took ~7 hr? |
@twhetzel Until now, nothing beyond this initial comment. I did just run the synonym sync Python part for Orphanet just now, since that is the part I noticed that for some reason appeared to be stuck a long time, and it completed within 11 seconds. I would mark this as a strange anomaly. The only other reason I can think of why it might have taken a long time is possibly due to multiple updates to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just one comment inline
- Update: Re-ran synonym sync part of pipeline and recommitted files. Mainly to face check an erroneous file save; the 'combined cases' file had only 'beep' as its contents in previous commit.
Build for:
Maybe this build isn't entirely necessary, given the simple changes of #671. But we are about done with this round of synonym sync and about to merge it, and it needs a build first. But this feature branch is still open, so I ought to build here instead.
We do however have some synonym-related OMIM changes (monarch-initiative/omim#132) still yet to be merged. Not sure if we need to run a build on #93 when those changes are merged.