Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add superclass to neurodegeneration, childhood-onset, with ataxia, tr… #8769

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

nicolevasilevsky
Copy link
Member

…emor, optic atrophy, and cognitive decline (MONDO:0030028)

and related classes (assert as child of neurodegenerative disorder)

  • remove duplicate synonyms
  • revise synonym scope

close #8492

…emor, optic atrophy, and cognitive decline (MONDO:0030028)

and related classes (assert as child of neurodegenerative disorder)

- remove duplicate synonyms
- revise synonym scope

close #8492
Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky thank you for all of your work on this issue!

I question whether the superclass should be 'inherited neurodegenerative disorder' instead of 'neurodegenerative disease' and 'hereditary disease.'

Can you please let me know what you think?

@nicolevasilevsky
Copy link
Member Author

good point, it was inferred to be an inherited neurodegenerative disorder but I updated the asserted superclass, per your suggestion.

@nicolevasilevsky nicolevasilevsky removed their assignment Feb 25, 2025
Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this one @nicolevasilevsky! I approve and will merge this PR.

@katiermullen katiermullen merged commit 3acdf72 into master Feb 25, 2025
1 check passed
@katiermullen katiermullen deleted the issue-8492 branch February 25, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants