Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of minSdkVersion upgrade to fix UT #1869

Merged
merged 4 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/testbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v3
with:
java-version: '17'
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -801,10 +801,8 @@
<string name="title_auto_transaction_number">Auto populate transaction number</string>

<!-- Notification Setting -->
<!-- Old string
<string name="title_notifications_repeating_transaction">Notification Scheduled Transaction overdue </string>
<string name="summary_notifications_repeating_transaction">Show notification for scheduled transaction overdue</string>
-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @wolfsolver , it is not safe to comment out lines blindly.

<string name="notification_channel_recurring">Scheduled Transaction Notification</string>
<string name="notification_channel_recurring__description">Overdue Scheduled Transaction Notification</string>

Expand Down
2 changes: 1 addition & 1 deletion app/src/test/resources/robolectric.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#

sdk=25
sdk=29

#robolectric.offline=true
8 changes: 3 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,19 @@ ext {
compileSdk = 34
targetSdk = 34
minSdkVersion = 26 // Android 8.0
buildToolsVersion = '30.0.2'
supportLibrary = '1.0.0'
ext.kotlin_version = '1.9.0'
ext.kotlin_version = '1.9.10'

// https://developer.android.com/topic/libraries/support-library/revisions.html
supportDependencies = [
core : "androidx.core:core:1.9.0",
cardView : "androidx.cardview:cardview:${supportLibrary}",
cardView : "androidx.cardview:cardview:1.0.0",
design : "com.google.android.material:material:1.8.0",
preference : "androidx.preference:preference:1.2.1",
recyclerView : "androidx.recyclerview:recyclerview:1.3.0",
annotation : "androidx.annotation:annotation:1.5.0",
appcompat : "androidx.appcompat:appcompat:1.6.1",
sqlite : "androidx.sqlite:sqlite:2.3.1",
gridLayout : "androidx.gridlayout:gridlayout:${supportLibrary}"
gridLayout : "androidx.gridlayout:gridlayout:1.0.0"
]
}

Expand Down
Loading