-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creating automatic transaction from SMS for database v19 #2205
Conversation
Pull from AMMEX-Master branch
Updated with additional RegEx to support more transactional sms. Changes are made in following methods extractTransRefNo, extractTransPayee, extractTransRefNo
I'm not sure that app has Auth for reading SMS... @guanlisheng what do you think? |
@wolfsolver, I developed this feature in the year 2017 and I am actively using this in the old App. I want to move to a newer version ASAP. That is why I started making changes to the general report as well. |
I understand, my concern was about I think that manifest does not have SMS permission... |
We need to add the following as well,
|
Added permission for Receive and Read SMS
In My Code, subcategid is ref. Hence updated with correct query to get the catgid.
Ok. I will check if something need to be change on play store. Can you prepare a little piece of description to inform user regarding changes in permissions? |
What is changes for DB 19? |
Since subcategory table doesn't exists, we donot required to have else block. all search will happen in vategory_v1 table
@wolfsolver , In db v19, there is no table for subcategory and the data got migrated to the category table. Due to this, automatic transactions are not created |
@wolfsolver , You can use the below info, Android Money Manager Ex application requires permission to read SMS to create automatic transactions. Users will be asked to allow permission to read SMS when enabling the option Settings > Behavior >Process Bank Transaction SMS. |
Uncommented the line for capturing the trans no.
Made changes for issue found by Codacy Static Code Analysis. Also few minor corrections in RegEx
@guanlisheng , @wolfsolver , I have made all the required changes to make this feature work. You can merge the changes to master and plan accordingly to include in future releases. However, I need to test around 75 cases to cover different types of transactional SMS. I will continue to test and make the required changes at the end of my testing. For Now, you can review and merge to master. |
We will check after stability of v1069 for DB compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me
Updated with additional RegEx to support more transactional sms. Changes are made in the following methods,
Also migrated query to support db version 19.
Release Notes: