Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating automatic transaction from SMS for database v19 #2205

Merged
merged 8 commits into from
Feb 8, 2025

Conversation

velmuruganc
Copy link
Contributor

@velmuruganc velmuruganc commented Feb 4, 2025

Updated with additional RegEx to support more transactional sms. Changes are made in the following methods,

  • extractTransRefNo
  • extractTransPayee
  • extractTransRefNo

Also migrated query to support db version 19.

Release Notes:

  1. Handled additional transactional SMS to support creating automatic transaction
  2. Now SMS Transaction processing is supported for db version 19

Pull from AMMEX-Master branch
Updated with additional RegEx to support more transactional sms. Changes are made in following methods
extractTransRefNo, extractTransPayee, extractTransRefNo
@velmuruganc velmuruganc changed the title Handled additional transaction sms to support creating automatic transaction Handled additional transactional sms to support creating automatic transaction Feb 4, 2025
@velmuruganc velmuruganc changed the title Handled additional transactional sms to support creating automatic transaction Handled additional transactional SMS to support creating automatic transaction Feb 4, 2025
@wolfsolver
Copy link
Member

I'm not sure that app has Auth for reading SMS... @guanlisheng what do you think?

@velmuruganc
Copy link
Contributor Author

@wolfsolver, I developed this feature in the year 2017 and I am actively using this in the old App. I want to move to a newer version ASAP. That is why I started making changes to the general report as well.

@wolfsolver
Copy link
Member

I understand, my concern was about I think that manifest does not have SMS permission...

@velmuruganc
Copy link
Contributor Author

I understand, my concern was about I think that manifest does not have SMS permission...

It is available in the manifest.
image

@velmuruganc
Copy link
Contributor Author

We need to add the following as well,

<!-- SMS Interface -->
<uses-permission android:name="android.permission.RECEIVE_SMS" />
<uses-permission android:name="android.permission.READ_SMS" />

Added permission for Receive and Read SMS
In My Code, subcategid is ref. Hence updated with correct query to get the catgid.
@velmuruganc velmuruganc changed the title Handled additional transactional SMS to support creating automatic transaction Handled additional transactional SMS to support creating automatic transaction and Added support for db version 19 Feb 4, 2025
@wolfsolver
Copy link
Member

Ok. I will check if something need to be change on play store. Can you prepare a little piece of description to inform user regarding changes in permissions?

@wolfsolver
Copy link
Member

What is changes for DB 19?

Since subcategory table doesn't exists, we donot required to have else block. all search will happen in vategory_v1 table
@velmuruganc
Copy link
Contributor Author

velmuruganc commented Feb 5, 2025

What is changes for DB 19?

@wolfsolver , In db v19, there is no table for subcategory and the data got migrated to the category table. Due to this, automatic transactions are not created

@velmuruganc
Copy link
Contributor Author

Member

@wolfsolver , You can use the below info,

Android Money Manager Ex application requires permission to read SMS to create automatic transactions. Users will be asked to allow permission to read SMS when enabling the option Settings > Behavior >Process Bank Transaction SMS.

image

Uncommented the line for capturing the trans no.
Made changes for issue found by Codacy Static Code Analysis.

Also few minor corrections in RegEx
@velmuruganc
Copy link
Contributor Author

velmuruganc commented Feb 6, 2025

@guanlisheng , @wolfsolver , I have made all the required changes to make this feature work. You can merge the changes to master and plan accordingly to include in future releases. However, I need to test around 75 cases to cover different types of transactional SMS. I will continue to test and make the required changes at the end of my testing.

For Now, you can review and merge to master.

@wolfsolver
Copy link
Member

We will check after stability of v1069 for DB compatibility.

Copy link
Contributor

@guanlisheng guanlisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me

@guanlisheng guanlisheng changed the title Handled additional transactional SMS to support creating automatic transaction and Added support for db version 19 Support creating automatic transaction from SMS for database v19 Feb 7, 2025
@guanlisheng guanlisheng merged commit b9bf5e9 into moneymanagerex:master Feb 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants