chore(ci): move releasing to GitHub Actions MONGOSH-1871 #2309
Conversation
Co-authored-by: Nikola Irinchev <[email protected]>
gagik
force-pushed
the
gagik/move-release-ga
branch
from
0edc03e to
187cfd2
Compare
| name: Release mongosh | ||
| on: | ||
| workflow_run: | ||
| workflows: ["CheckQL", "Run Smoke Tests", "evergreen"] |
There was a problem hiding this comment.
I am not sure if evergreen is considered a workflow since it seems to be created by a bot/integration(?). Could leave and see what happens or just make it manual-only
gagik
force-pushed
the
gagik/move-release-ga
branch
from
187cfd2 to
8bfe843
Compare
gagik
force-pushed
the
gagik/individual-publishing
branch
2 times, most recently
from
1561be9 to
3c557da
Compare
gagik
force-pushed
the
gagik/move-release-ga
branch
from
707000e to
7868a6c
Compare
Co-authored-by: Nikola Irinchev <[email protected]>
gagik
force-pushed
the
gagik/move-release-ga
branch
from
7868a6c to
990f8ee
Compare
gagik
changed the title
| ['merge', '--squash', `origin/release/${mongoshVersion}`], | ||
| commandOptions | ||
| ); | ||
| spawnSync( |
There was a problem hiding this comment.
I guess this essentially merges the PR but wondering if it'd be worth using GitHub CLI here instead to i.e. have reference to the original PR naming when merging. Don't know how easy it is with how our GitHub Actions Bot token works
There was a problem hiding this comment.
Yeah, right now this pushes from evergreen, right? Do we even have permissions for that?
| { isDryRun = false, useAuxiliaryPackagesOnly = false }, | ||
| listNpmPackages: typeof listNpmPackagesFn = listNpmPackagesFn, |
There was a problem hiding this comment.
getting rid of this helper so we can share more code
| working_dir: src | ||
| shell: bash | ||
| script: | | ||
| set -e | ||
| set -x |
There was a problem hiding this comment.
Can we write the secrets first, then turn set -x on after so that it's turned on for the rest of the script? It's really helpful when debugging CI issues
| ['merge', '--squash', `origin/release/${mongoshVersion}`], | ||
| commandOptions | ||
| ); | ||
| spawnSync( |
There was a problem hiding this comment.
Yeah, right now this pushes from evergreen, right? Do we even have permissions for that?
Built on top of #2289.
To Do: