LG-3814: MongoNav LiveExample + CodeDocs #333
Open
+119
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruugey
reviewed
Dec 5, 2023
bruugey
reviewed
Dec 5, 2023
package.json
Outdated
| @@ -88,6 +87,7 @@ | |||
| "@leafygreen-ui/tokens": "^2.2.0", | |||
| "@leafygreen-ui/tooltip": "^11.0.0", | |||
| "@leafygreen-ui/typography": "^18.0.1", | |||
| "@lg-private/mongo-nav": "^13.1.2", | |||
| @@ -92,6 +92,7 @@ export const Knob = ({ | |||
| value={value} | |||
| onChange={onChange} | |||
| className={cx(inputStyle, rest.className)} | |||
| popoverZIndex={999} | |||
utils/_getComponentResources.tsx
Outdated
Comment on lines
51
to
55
| let namespace = '@leafygreen-ui'; | ||
|
|
||
| if (PRIVATE_PACKAGES.includes(componentName)) { | ||
| namespace = '@lg-private'; | ||
| } |
There was a problem hiding this comment.
const namespace = PRIVATE_PACKAGES.includes(componentName) ? '@lg-private' : '@leafygreen-ui'
There was a problem hiding this comment.
I wrote this this way since if we were to include lg-chat in the future, we'd want if / else if
utils/_getComponentResources.tsx
Outdated
Comment on lines
73
to
77
| let namespace = '@leafygreen-ui'; | ||
|
|
||
| if (PRIVATE_PACKAGES.includes(componentName)) { | ||
| namespace = '@lg-private'; | ||
| } |
utils/_getComponentResources.tsx
Outdated
Comment on lines
98
to
104
| let namespace = '@leafygreen-ui'; | ||
| if (typeof componentName !== 'string') return null; | ||
|
|
||
| if (PRIVATE_PACKAGES.includes(componentName)) { | ||
| namespace = '@lg-private'; | ||
| } | ||
|
|
There was a problem hiding this comment.
ternary here as well
utils/getComponentStories.ts
Outdated
Comment on lines
17
to
22
| let namespace = '@leafygreen-ui'; | ||
|
|
||
| if (PRIVATE_PACKAGES.includes(kebabName)) { | ||
| namespace = '@lg-private'; | ||
| } | ||
|
|
There was a problem hiding this comment.
(could also create a getNamespaceFromPackageName function for future extensibility)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.