-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure docs per Diátaxis framework #233
Conversation
ab68e23
to
ae26783
Compare
docs/source/intro/configure.rst
Outdated
:setting:`USER`, :setting:`PASSWORD`, and :setting:`PORT` (if 27017) may also | ||
be optional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have it say, if you do not require authentication, :setting:USER
and :setting:PASSWORD
should be omitted.
:setting:`USER`, :setting:`PASSWORD`, and :setting:`PORT` (if 27017) may also | |
be optional. | |
:setting:`USER` and :setting:`PASSWORD` should be omitted if you do not require authentication. | |
:setting:`PORT` (if 27017) may also be optional. |
MONGODB_URI = "mongodb+srv://my_user:[email protected]/myDatabase?retryWrites=true&w=majority&tls=false" | ||
DATABASES["default"] = django_mongodb_backend.parse_uri(MONGODB_URI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/source/intro/index.rst
Outdated
If you're new to Django_, you might want to start by getting an idea of | ||
what it's like. The :doc:`official Django tutorial | ||
<django:intro/tutorial01>` is a great place to start. Once you understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also point to our Getting Started on the MongoDB docs as well. The Django Tutorial site won't make it clear how they should run the app using the library.
docs/source/ref/utils.rst
Outdated
.. function:: parse_uri(uri, conn_max_age=0, test=None) | ||
|
||
Parses a MongoDB URI into a dictionary suitable for Django's | ||
:setting:`DATABASES` setting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have RTD configured to build PRs for previewing and if not, can we configure RTD to build PRs for previewing? |
I'm not aware of such functionality. To build this locally:
Add thist to your Then |
Thanks! I enabled "build PRs" in RTD so next push should do it. 🤞 |
ae26783
to
1986472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any interest in adhering more strictly to Diataxis forms of documentation? Otherwise LGTM, thanks!
I used the names that Django's docs use - tutorials: "intro", reference: "ref", explanation: "topics", how-to: [none yet]. |
Add intro, reference, and topic sections.
1986472
to
6ba78c3
Compare
Add intro, reference, and topic sections
The Diátaxis framework is how Django's documentation is structured, so anyone coming from Django will see the parallels.