Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): allow to disable telemetry through settings INTELLIJ-12 #8

Merged
merged 12 commits into from
Jun 12, 2024

Conversation

kmruiz
Copy link
Contributor

@kmruiz kmruiz commented Jun 12, 2024

Description

Notifies a plugin user, the first time the plugin is activated, that we use anonymous telemetry. In the notification balloon there is an action to disable the telemetry from there. In the plugin settings there is a checkbox that allows us to toggle telemetry any time.

signal-2024-06-12-14-43-50-481
signal-2024-06-12-14-43-50-481-1

Checklist

Open Questions

@kmruiz kmruiz self-assigned this Jun 12, 2024
@github-actions github-actions bot added the feature Adds a new feature. label Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

Coverage Report

Overall Project 77.59% -12.33%
Files changed 49.77% 🚫

Module Coverage
jetbrains-plugin 78.31% -20.27% 🚫
Files
Module File Coverage
jetbrains-plugin TelemetryService.kt 100%
TelemetryMessages.kt 100%
SettingsMessages.kt 100%
PluginSettings.kt 90.65% -9.35%
ActivatePluginPostStartupActivity.kt 38.84% -50.41% 🚫
PluginSettingsConfigurable.kt 0% 🚫

remoteRobot,
remoteComponent,
) {
val ok by lazy {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's maybe do some knowledge sharing at some point about what all this 'helpful' syntax in Kotlin means exactly (it's very dense and expressive, but that also means that if you don't start out knowing what it does, it's relatively hard to tell)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree. The testing framework and the settings heavily depend on delegates (this lazy thing) so it's good to make sure that everyone is comfortable with it.

Co-authored-by: Anna Henningsen <[email protected]>
@kmruiz kmruiz merged commit 0625244 into main Jun 12, 2024
11 checks passed
@kmruiz kmruiz deleted the chore/INTELLIJ-12 branch June 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants