-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): allow to disable telemetry through settings INTELLIJ-12 #8
Conversation
...s/jetbrains-plugin/src/main/kotlin/com/mongodb/jbplugin/ActivatePluginPostStartupActivity.kt
Outdated
Show resolved
Hide resolved
packages/jetbrains-plugin/src/main/kotlin/com/mongodb/jbplugin/settings/PluginSettings.kt
Show resolved
Hide resolved
packages/jetbrains-plugin/src/main/resources/messages/TelemetryBundle.properties
Outdated
Show resolved
Hide resolved
Coverage Report
Files
|
.../jetbrains-plugin/src/test/kotlin/com/mongodb/jbplugin/observability/TelemetryServiceTest.kt
Outdated
Show resolved
Hide resolved
remoteRobot, | ||
remoteComponent, | ||
) { | ||
val ok by lazy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's maybe do some knowledge sharing at some point about what all this 'helpful' syntax in Kotlin means exactly (it's very dense and expressive, but that also means that if you don't start out knowing what it does, it's relatively hard to tell)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree. The testing framework and the settings heavily depend on delegates (this lazy thing) so it's good to make sure that everyone is comfortable with it.
Co-authored-by: Anna Henningsen <[email protected]>
Description
Notifies a plugin user, the first time the plugin is activated, that we use anonymous telemetry. In the notification balloon there is an action to disable the telemetry from there. In the plugin settings there is a checkbox that allows us to toggle telemetry any time.
Checklist
Open Questions