-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-196976: Publish compliancePolicy commands #2494
Conversation
* - -h, --help | ||
- | ||
- false | ||
- help for disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- help for disable | |
- Help information for disable command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is also automatically generated format is help for and its the same pattern across all commands
* - -w, --watch | ||
- | ||
- false | ||
- Flag that indicates whether to watch the command until it completes its execution or the watch times out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Flag that indicates whether to watch the command until it completes its execution or the watch times out. | |
- Flag that indicates whether to watch the command until it completes its execution or the time out and stop watching the command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: The flag --watch is used across other commands and has been reviewed in the past. Updating this will update docs for all related commands.
I think "and stop watching the command" seems a bit more confusing here and would prefer to keep as is.
* - -h, --help | ||
- | ||
- false | ||
- help for enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- help for enable | |
- Help information for enable command. |
* - --projectId | ||
- string | ||
- false | ||
- Hexadecimal string that identifies the project to use. This option overrides the settings in the configuration file or environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Hexadecimal string that identifies the project to use. This option overrides the settings in the configuration file or environment variable. | |
- Hexadecimal string that identifies the project to use. This option overrides the settings in the configuration file and the environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: This flag is used in all projects, and it will get updated in all docs and we'll have many updates. if we really want to update the copy of this flag we should do in another PR
* - -w, --watch | ||
- | ||
- false | ||
- Flag that indicates whether to watch the command until it completes its execution or the watch times out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Flag that indicates whether to watch the command until it completes its execution or the watch times out. | |
- Flag that indicates whether to watch the command until it completes its execution or time out and stop watching the command. |
docs/atlascli/command/atlas-backups-compliancePolicy-encryptionAtRest.txt
Outdated
Show resolved
Hide resolved
docs/atlascli/command/atlas-backups-compliancePolicy-policies-ondemand-create.txt
Outdated
Show resolved
Hide resolved
docs/atlascli/command/atlas-backups-compliancePolicy-policies-ondemand-create.txt
Outdated
Show resolved
Hide resolved
docs/atlascli/command/atlas-backups-compliancePolicy-policies-ondemand-update.txt
Outdated
Show resolved
Hide resolved
docs/atlascli/command/atlas-backups-compliancePolicy-policies-ondemand-update.txt
Outdated
Show resolved
Hide resolved
@kanchana-mongodb rfal, I've updated everything that is not --projectId (global flag), --help description or --watch, which are common flags and changing them would change docs everywhere, so better to address separately if we have strong opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-196976
Closes #[issue number]
Checklist
make fmt
and formatted my codeFurther comments