Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-196976: Publish compliancePolicy commands #2494

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

blva
Copy link
Collaborator

@blva blva commented Dec 5, 2023

Proposed changes

Jira ticket: CLOUDP-196976

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva changed the title CLOUDP-196796: Publish compliancePolicy commands CLOUDP-196976: Publish compliancePolicy commands Dec 5, 2023
@blva blva marked this pull request as ready for review December 5, 2023 09:24
@blva blva requested a review from a team as a code owner December 5, 2023 09:24
@blva blva requested a review from a team December 5, 2023 09:24
gssbzn
gssbzn previously approved these changes Dec 5, 2023
* - -h, --help
-
- false
- help for disable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- help for disable
- Help information for disable command.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is also automatically generated format is help for and its the same pattern across all commands

* - -w, --watch
-
- false
- Flag that indicates whether to watch the command until it completes its execution or the watch times out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Flag that indicates whether to watch the command until it completes its execution or the watch times out.
- Flag that indicates whether to watch the command until it completes its execution or the time out and stop watching the command.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The flag --watch is used across other commands and has been reviewed in the past. Updating this will update docs for all related commands.

I think "and stop watching the command" seems a bit more confusing here and would prefer to keep as is.

* - -h, --help
-
- false
- help for enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- help for enable
- Help information for enable command.

* - --projectId
- string
- false
- Hexadecimal string that identifies the project to use. This option overrides the settings in the configuration file or environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Hexadecimal string that identifies the project to use. This option overrides the settings in the configuration file or environment variable.
- Hexadecimal string that identifies the project to use. This option overrides the settings in the configuration file and the environment variable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This flag is used in all projects, and it will get updated in all docs and we'll have many updates. if we really want to update the copy of this flag we should do in another PR

* - -w, --watch
-
- false
- Flag that indicates whether to watch the command until it completes its execution or the watch times out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Flag that indicates whether to watch the command until it completes its execution or the watch times out.
- Flag that indicates whether to watch the command until it completes its execution or time out and stop watching the command.

@blva
Copy link
Collaborator Author

blva commented Dec 5, 2023

@kanchana-mongodb rfal, I've updated everything that is not --projectId (global flag), --help description or --watch, which are common flags and changing them would change docs everywhere, so better to address separately if we have strong opinion.

Copy link
Contributor

@kanchana-mongodb kanchana-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit c347c5e into master Dec 5, 2023
12 checks passed
@blva blva deleted the CLOUDP-196796 branch December 5, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants