Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-196956: Added Deployments Tags generation #2536

Merged
merged 1 commit into from
Jan 6, 2024
Merged

CLOUDP-196956: Added Deployments Tags generation #2536

merged 1 commit into from
Jan 6, 2024

Conversation

igor-karpukhin
Copy link
Contributor

Proposed changes

Added Deployment tags for the atlas kubernetes config generate command

Jira ticket: CLOUDP-196956

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@igor-karpukhin igor-karpukhin requested review from a team, helderjs and s-urbaniak January 3, 2024 12:47
@igor-karpukhin
Copy link
Contributor Author

Hi @gssbzn please take a look when you have time. Thanks!

blva
blva approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGTEV (triggered k8s e2e tests just to double-check)

@igor-karpukhin igor-karpukhin merged commit 71294d2 into master Jan 6, 2024
18 checks passed
@igor-karpukhin igor-karpukhin deleted the CLOUDP-196956/support-deployment-tags branch January 6, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helderjs helderjs helderjs approved these changes

@blva blva blva approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-karpukhin @helderjs @blva