Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-220676: NPE in default_setter_opts.go #2537

Merged
merged 3 commits into from
Jan 3, 2024
Merged

CLOUDP-220676: NPE in default_setter_opts.go #2537

merged 3 commits into from
Jan 3, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jan 3, 2024 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-220676

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

blva
blva previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo marked this pull request as ready for review January 3, 2024 16:07
@andreaangiolillo andreaangiolillo requested a review from a team January 3, 2024 16:07
blva
blva previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo requested a review from blva January 3, 2024 16:18
@andreaangiolillo andreaangiolillo merged commit 77c94f9 into master Jan 3, 2024
16 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-220676 branch January 3, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibulca tibulca tibulca approved these changes

@blva blva blva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreaangiolillo @tibulca @blva