Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-34594 clarify use case for deleting network containers #2538

Merged
merged 3 commits into from
Jan 5, 2024
Merged

DOCSP-34594 clarify use case for deleting network containers #2538

merged 3 commits into from
Jan 5, 2024
+3 −3

Conversation

kanchana-mongodb
Copy link
Contributor

Proposed changes

Jira ticket: DOCSP-34594

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@kanchana-mongodb kanchana-mongodb requested a review from a team as a code owner January 4, 2024 15:18
@kanchana-mongodb kanchana-mongodb requested a review from a team January 4, 2024 15:18
kyuan-mongodb
kyuan-mongodb previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@kyuan-mongodb kyuan-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % question!

docs/atlascli/command/atlas-networking-containers-delete.txt Outdated Show resolved Hide resolved
@gssbzn
Copy link
Collaborator

gssbzn commented Jan 4, 2024

needs a run on make gen-docs

gssbzn
gssbzn approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanchana-mongodb kanchana-mongodb merged commit 56e7401 into mongodb:master Jan 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@kyuan-mongodb kyuan-mongodb kyuan-mongodb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanchana-mongodb @gssbzn @kyuan-mongodb