Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: simplify nil check for total count #2541

Merged
merged 1 commit into from
Jan 5, 2024
Merged

task: simplify nil check for total count #2541

merged 1 commit into from
Jan 5, 2024

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jan 5, 2024

Getters on the new SDK are nil safe, we should prefer to use those

@gssbzn gssbzn marked this pull request as ready for review January 5, 2024 11:03
@gssbzn gssbzn requested a review from a team January 5, 2024 11:03
@gssbzn gssbzn merged commit 6b6b59b into master Jan 5, 2024
17 checks passed
@gssbzn gssbzn deleted the simplify-nil-check branch January 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibulca tibulca tibulca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @tibulca