Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-297778 Change syntax of overrides based on spec update #3594

Merged
merged 2 commits into from
Jan 31, 2025
Merged

CLOUDP-297778 Change syntax of overrides based on spec update #3594

merged 2 commits into from
Jan 31, 2025

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Jan 31, 2025 •
edited
Loading

Proposed changes

Change syntax of overrides based on spec update

Jira ticket: CLOUDP-297778

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review January 31, 2025 10:39
@fmenezes fmenezes requested a review from a team as a code owner January 31, 2025 10:39
@apix-bot APIx Bot
Copy link
Contributor

apix-bot bot commented Jan 31, 2025

Coverage Report 📈

Branch Commit Coverage
master b9b95f6 39.1%
CLOUDP-297778 7f98ca4 39.1%
Difference 0%

@fmenezes fmenezes merged commit 6e2fcbc into master Jan 31, 2025
22 checks passed
@fmenezes fmenezes deleted the CLOUDP-297778 branch January 31, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmenezes @jeroenvervaeke