maintain highlight in navbar #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Feb 25, 2025
frontend/src/navbar/navbar.js
Outdated
| @@ -14,6 +14,9 @@ module.exports = app => app.component('navbar', { | |||
| inject: ['state'], | |||
| data: () => ({ showFlyout: false }), | |||
| computed: { | |||
| dashboardView() { | |||
| return this.$route.fullPath.includes('dashboard'); | |||
There was a problem hiding this comment.
Better to make this a startsWith in case someone has a document with _id === 'dashboard'. I'd prefer if this was an explicit list based on the current route's name though
frontend/src/navbar/navbar.html
Outdated
| @@ -12,11 +12,11 @@ | |||
| <a | |||
| href="#/" | |||
| class="inline-flex items-center px-1 pt-1 border-b-2 text-sm font-medium" | |||
| :class="routeName === 'root' ? 'text-gray-900 border-ultramarine-500' : 'border-transparent text-gray-500 hover:border-gray-300 hover:text-gray-700'">Documents</a> | |||
| :class="!dashboardView ? 'text-gray-900 border-ultramarine-500' : 'border-transparent text-gray-500 hover:border-gray-300 hover:text-gray-700'">Documents</a> | |||
There was a problem hiding this comment.
This won't work when we have more nav items (I currently have a new "shell" tab WIP here: https://github.com/mongoosejs/studio/tree/vkarpov15/shell)
There was a problem hiding this comment.
I figured I would adjust it if we ever got to that point. I'll make the necessary changes
vkarpov15
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.