Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This push add 2 main features:
(See the last item in the activity feed. This has nothing to do with mentions, it relies on which contacts are linked to the post in the existing way).
In this commit, mentions look like this in the edit box @"Tony Smith", and go into the database as a token {{{CONTACT-ID:xxxx-xxxx-xxxxxx|Tony Smith}}}. The reason the name is also in the token is to act as a fall back name only, should the contact get deleted, the user's intent does not get lost. The view will always attempt to retrieve the up to date name information from the databasae.
There are no breaking changes.
Currently the only contacts that can be selected are the ones already linked to the post in the submenu. My preference for monica is actually removal of contacts in this post form entirely and relying on mentions to connect the post to users only. That way, any contacts in the journal can be picked when making a mention. This can be introduced in a non-breaking way if needed (by adding all the mentions at the bottom to all previously linked contacts to all posts).
To do:
I wanted the thoughts of @djaiss @asbiin and the community before proceeding further.