Added support for storage flags in Codec #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like #50 incorporates the flags on Codec idea. |
alexandru
force-pushed
the
master
branch
3 times, most recently
from
d97b560
to
18da705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setting and reading of the storage flags (as described in https://github.com/memcached/memcached/blob/master/doc/protocol.txt) into the public API.
The intended point of usage is in the
Codectrait's methods (i.e. serde operations should be aware of the flags, such as compression and similar).Few notes:
FakeMemcachedinternals don't support the flags so ignoring/setting 0s where neededMemcachedSuite.increment-defaultis failing (it seems that it's been failing in previous builds as well)BaseCodecsaccept but otherwise ignore the flag values