-
Notifications
You must be signed in to change notification settings - Fork 3
Update Inferno to newer version #5
base: gh-pages
Are you sure you want to change the base?
Conversation
A lot of |
Got this when trying to build:
|
@Elfet Strange, I don't seem to get that error. Is it when building |
In ticket-rendering. Fresh clone, npm i. :) |
@Elfet I still don't have any issues. Make sure you have node v6.4. |
4.5.10 сент. 2016 г., в 14:43, Dominic Gannaway [email protected] написал(а):@Elfet I still don't have any issues. Make sure you have node v6.4.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/monkberry/benchmark","title":"monkberry/benchmark","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/monkberry/benchmark"}},"updates":{"snippets":[{"icon":"PERSON","message":"@trueadm in #5: @Elfet I still don't have any issues. Make sure you have node v6.4."}],"action":{"name":"View Pull Request","url":"#5 (comment)"}}} |
Actually, I was right the first time. You'll need node v6+, I just tried node 4 and I get the same error. |
@Elfet Any luck getting it working? |
@Elfet I've pushed some changes, that should hopefully fix your problem. |
Still falling on stable 4.5.0, but okay on 6.5.0. |
@Elfet Awesome. Glad you got it working. Are you going to merge? |
Yes, i'm going to merge. But it will be better if it will be possible to build in on stable version of node. |
@Elfet I can see todos in the commits too? |
Todos in commits? Sorry, does not understand you:( |
@Elfet I don't understand what the issue is with the PR? the |
Every think is okay. I just was thinking what you are going to make possible to build bundle on stable node 4.5? |
@trueadm can you also update single-point benchmark to new inferno? |
@Elfet done :) |
Now got this:
😞 |
This is an NPM bug unfortunately. You need to manually do 'npm install --save inferno@alpha11' in the relevant directories and it will work. I'm going to raise an issue at NPM about it. |
Updated Inferno version to 1.0-alpha3, along with babel-plugin-inferno to 1.0-alpha4. Inferno 1.0 is a lot faster than 0.7, which was the version previously used.