Skip to content

Commit

Permalink
impr(typing test): limit line length to 70 characters
Browse files Browse the repository at this point in the history
  • Loading branch information
@Miodec
Miodec committed Apr 24, 2024
1 parent 0a5e732 commit 1b5bb70
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions frontend/src/styles/keymap.scss
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#keymap {
font-size: 1rem;
display: grid;
grid-template-rows: 1fr 1fr 1fr;
justify-content: center;
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/styles/test.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,9 @@

#typingTest {
position: relative;
max-width: 70ch;
width: 100%;
margin: 0 auto;
}

.ssWatermark {
Expand Down Expand Up @@ -473,6 +476,7 @@
}

#wordsInput {
font-size: 1rem;
opacity: 0;
padding: 0;
margin: 0 auto;
Expand All @@ -487,6 +491,7 @@
}

#capsWarning {
font-size: 1rem;
background: var(--main-color);
color: var(--bg-color);
display: table;
Expand Down Expand Up @@ -920,6 +925,7 @@
}

#restartTestButton {
font-size: 1rem;
margin: 1rem auto 0 auto;
display: flex;
padding: 1em 2em;
Expand Down Expand Up @@ -1081,6 +1087,7 @@
}
#memoryTimer,
#layoutfluidTimer {
font-size: 1rem;
background: var(--main-color);
color: var(--bg-color);
padding: 1rem;
Expand Down Expand Up @@ -1111,6 +1118,7 @@
}

#testModesNotice {
font-size: 1rem;
display: flex;
flex-wrap: wrap;
color: var(--sub-color);
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/ts/config.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1660,7 +1660,7 @@ export function setFontSize(fontSize: number, nosave?: boolean): boolean {

config.fontSize = fontSize;

$("#words, #caret, #paceCaret, #miniTimerAndLiveWpm").css(
$("#caret, #paceCaret, #miniTimerAndLiveWpm, #typingTest").css(
"fontSize",
fontSize + "rem"
);
Expand Down

4 comments on commit 1b5bb70

@mizaagi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP page width

@AbdalrhmanHamza
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please return the page width I can't use the website now

@KagoraTheGrindcoreAddict
Copy link

@KagoraTheGrindcoreAddict KagoraTheGrindcoreAddict commented on 1b5bb70 Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No max width setting breaks tape mode and UI placement on ultrawide/super ultrawide monitors, making it function as if the plus three funbox is on the entire time.
mtimage

Found an image of how it was before.
2024-03-18_18-55

I don't have a full screen screenshot of an end screen max width completed test but this is how it used to stretch and I always found it more readable.
image

image

Apologizes for 1172ing you.

@AlvinCuiYue
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update change is really stupid. Why remove the choice to change the line length entirely? Even if it is proven "scientifically" to be better for attention or whatever, it doesn't mean everyone is going to prefer it. Please Devs, change it back to customizable ASAP.

Please sign in to comment.