This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Adds some handlers and project creation state toggles in ProjectOperations #9536
Open
netonjm
wants to merge
3
commits into
main
Choose a base branch
from
fix-984930
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrward
reviewed
Jan 10, 2020
main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/ProjectOperations.cs
Outdated
Show resolved
Hide resolved
mrward
reviewed
Jan 10, 2020
main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/ProjectOperations.cs
Outdated
Show resolved
Hide resolved
mrward
reviewed
Jan 10, 2020
main/src/core/MonoDevelop.Ide/MonoDevelop.Ide/ProjectOperations.cs
Outdated
Show resolved
Hide resolved
mrward
reviewed
Jan 15, 2020
main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs
Outdated
Show resolved
Hide resolved
mrward
reviewed
Jan 15, 2020
main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs
Show resolved
Hide resolved
mrward
approved these changes
Jan 15, 2020
slluis
approved these changes
Jan 15, 2020
Therzok
approved these changes
Jan 15, 2020
sevoku
approved these changes
Jan 16, 2020
rebased! |
@monojenkins rebase |
Fixes VSTS #984930 - Get to code can be re-entered during new project flow
monojenkins
force-pushed
the
fix-984930
branch
from
January 22, 2020 20:50
6120466
to
7ac0fcd
Compare
@mrward any idea how this change might cause the NuGet test failure?
|
Should have no affect on NuGet. Looking at the test report the screenshots have some error about being unable to load Xamarin.Ide. |
Xamarin.Ide is being loaded. The problem seems to be a null ref in Get to code looking at the IDE log in the failing test.
That RefreshViewEnableStates method is new I think. |
ooh! @mrward thanks! |
good catch! thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some handlers and project creation state toggles in ProjectOperations
Fixes VSTS #984930 - Get to code can be re-entered during new project flow
Requires https://github.com/xamarin/md-addins/pull/6161