This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Allow the startup to complete without taking control of the runloop. #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have enough context to know how to review this. |
Therzok
reviewed
Jan 24, 2020
| @@ -761,7 +784,9 @@ public static int Main (string[] args, IdeCustomizer customizer = null) | |||
| BrandingService.ApplicationName | |||
| ), ex); | |||
| } finally { | |||
| Runtime.Shutdown (); | |||
| if (controlMainLoop) { | |||
There was a problem hiding this comment.
Do we need to refactor this controlMainLoop code? It might end up cleaner if we had 2 separate runloop runners (i.e. in IdeCustomizer), with different implementations and simplify all the signatures that have changed around here?
iainx
force-pushed
the
optional-mainloop
branch
from
b6d018c
to
cdb5527
Compare
Separate the initialization/shutdown sequence into separate methods just on the offchance that a separate runloop might be used.
iainx
force-pushed
the
optional-mainloop
branch
from
cdb5527
to
6c6a281
Compare
Therzok
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the initialization/shutdown sequence into separate methods just on the offchance that a separate runloop might be used. You never know...