Fix some warnings

mono · Oct 12, 2023 · 4f54e8a · 4f54e8a
1 parent 2711105
commit 4f54e8a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -11,7 +11,9 @@
     }
   ],
   "cSpell.words": [
+    "langversion",
     "Preprocess",
-    "reimplementation"
+    "reimplementation",
+    "Xunit"
   ]
 }
diff --git a/Mono.TextTemplating.Roslyn/RoslynCodeCompiler.cs b/Mono.TextTemplating.Roslyn/RoslynCodeCompiler.cs
@@ -1,6 +1,7 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Text;
@@ -102,7 +103,7 @@ CodeCompilerResult CompileFileInternal (
 				var startLinePosition = location.StartLinePosition;
 				var endLinePosition = location.EndLinePosition;
 				return new CodeCompilerError {
-					Message = x.GetMessage (),
+					Message = x.GetMessage (CultureInfo.CurrentCulture),
 					Column = startLinePosition.Character,
 					Line = startLinePosition.Line,
 					EndLine = endLinePosition.Line,

diff --git a/Mono.TextTemplating/Mono.TextTemplating.csproj b/Mono.TextTemplating/Mono.TextTemplating.csproj
@@ -16,16 +16,18 @@
     <PackageValidationBaselineVersion>2.2.1</PackageValidationBaselineVersion>
     <PackageReadmeFile>readme.md</PackageReadmeFile>
     <NeutralLanguage>en-US</NeutralLanguage>
+    <!-- ignore the _._ files that suppress compat targets in newer frameworks -->
+    <NoWarn>$(NoWarn);NU5129</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
     <!-- limit to 6.0 so that the MSBuild task can load on .NET 6.0 -->
     <PackageReference Include="System.CodeDom" Version="6.0.0" Condition="'$(TargetFramework)'!='net472'" />
     <None Include="readme.md" Pack="true" PackagePath="\" />
     <None Include="package\Mono.TextTemplating.targets" Pack="true" PackagePath="buildTransitive\net461\Mono.TextTemplating.targets" />
-    <None Include="package\Mono.TextTemplating.targets" Pack="true" PackagePath="buildTransitive\net472\_._" />
+    <None Include="package\_._" Pack="true" PackagePath="buildTransitive\net472\_._" />
     <None Include="package\Mono.TextTemplating.targets" Pack="true" PackagePath="buildTransitive\netcoreapp2.0\Mono.TextTemplating.targets" />
-    <None Include="package\Mono.TextTemplating.targets" Pack="true" PackagePath="buildTransitive\net6.0\_._" />
+    <None Include="package\_._" Pack="true" PackagePath="buildTransitive\net6.0\_._" />
   </ItemGroup>
 
   <ItemGroup>