Skip to content

Commit

Permalink
Ensure that CI tests are passing
Browse files Browse the repository at this point in the history
Also remove both the `phpcpd` command (deprecated) and
the `phpdoc` command, being replaced by `moodle-cs`.
  • Loading branch information
stronk7 committed Mar 30, 2024
1 parent 8fc9c87 commit 170623f
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 23 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,6 @@ jobs:
if: ${{ !cancelled() }}
run: moodle-plugin-ci phplint

- name: PHP Copy/Paste Detector
continue-on-error: true # This step will show errors but will not fail
if: ${{ !cancelled() }}
run: moodle-plugin-ci phpcpd

- name: PHP Mess Detector
continue-on-error: true # This step will show errors but will not fail
if: ${{ !cancelled() }}
Expand All @@ -140,15 +135,6 @@ jobs:
if: ${{ !cancelled() }}
run: moodle-plugin-ci codechecker --max-warnings 0

- name: Moodle PHPDoc Checker
if: ${{ !cancelled() }}
run: |
if [ ${{ matrix.plugin-ci }} == "^3" ]; then
moodle-plugin-ci phpdoc
else
moodle-plugin-ci phpdoc --max-warnings 0
fi
- name: Validating
if: ${{ !cancelled() }}
run: moodle-plugin-ci validate
Expand Down
18 changes: 9 additions & 9 deletions lang/en/local_codechecker.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,27 +36,27 @@
php run.php local/codechecker';
$string['error_find'] = 'Folder search failed';
$string['exclude'] = 'Exclude';
$string['other_eol'] = 'Whitespace at end of line';
$string['other_tab'] = 'Tab character not permitted';
$string['other_toolong'] = 'Line longer than maximum 180 characters';
$string['other_ratherlong'] = 'Line longer than recommended 132 characters';
$string['other_crlf'] = 'Windows (CRLF) line ending instead of just LF (reporting only first occurrence)';
$string['other_missinglf'] = 'Missing LF at end of file (use exactly one)';
$string['other_extralfs'] = 'Extra blank line(s) at end of file (use exactly one)';
$string['filesfound'] = 'Files found: {$a}';
$string['filesummary'] = '{$a->path} - {$a->count}';
$string['includewarnings'] = 'Include warnings';
$string['info'] = '<p>Checks code against some aspects of the {$a->link}.</p>
<p>Enter a path relative to the Moodle code root, for example: {$a->path}.</p>
<p>You can enter either a specific PHP file, or to a folder to check all the files it contains.
Multiple entries are supported (files or folders), one per line.</p>
<p>To exclude files, a comma separated list of substr matching paths can be used, for example: {$a->excludeexample}. Asterisks are allowed as wildchars at any place.</p>';
$string['includewarnings'] = 'Include warnings';
$string['invalidpath'] = 'Invalid path {$a}';
$string['moodlecodingguidelines'] = 'Moodle coding guidelines';
$string['numerrorswarnings'] = '{$a->errors} error(s) and {$a->warnings} warning(s)';
$string['other_crlf'] = 'Windows (CRLF) line ending instead of just LF (reporting only first occurrence)';
$string['other_eol'] = 'Whitespace at end of line';
$string['other_extralfs'] = 'Extra blank line(s) at end of file (use exactly one)';
$string['other_missinglf'] = 'Missing LF at end of file (use exactly one)';
$string['other_ratherlong'] = 'Line longer than recommended 132 characters';
$string['other_tab'] = 'Tab character not permitted';
$string['other_toolong'] = 'Line longer than maximum 180 characters';
$string['path'] = 'Path(s) to check';
$string['privacy:metadata'] = 'The Code checker plugin does not store any personal data.';
$string['pluginname'] = 'Code checker';
$string['privacy:metadata'] = 'The Code checker plugin does not store any personal data.';
$string['recheckfile'] = 'Re-check just this file';
$string['showstandard'] = 'Display phpcs standard associated with a problem';
$string['success'] = 'Well done!';
Expand Down

0 comments on commit 170623f

Please sign in to comment.