Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 📦 Update moonbeam-types-bundle #3160

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

timbrinded
Copy link
Contributor

@timbrinded timbrinded commented Jan 28, 2025

What does it do?

  • Update the moonbeam-types-bundle to use new package name @moonbeam-foundation/types-bundle to match our api-augment npm pkg
  • Fixes types bundle to properly annotate the rpcs via polkadotJS
    e.g.
    image

What value does it bring to the blockchain users?

Able to call the custom RPCs properly via PolkadotJS!

@timbrinded timbrinded added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2420 KB (no changes) 🚨

Moonbeam runtime: 2404 KB (no changes) 🚨

Moonriver runtime: 2400 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨

Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨

Moonriver runtime: 2400 KB (+388 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Coverage Report

@@                         Coverage Diff                         @@
##           master   refactor/update-types-bundle-pkg     +/-   ##
===================================================================
  Coverage   74.59%                             74.59%   0.00%     
  Files         380                                380             
  Lines       96035                              96035             
===================================================================
  Hits        71632                              71632             
  Misses      24403                              24403             
Files Changed Coverage

Coverage generated Wed Jan 29 17:11:42 UTC 2025

@timbrinded timbrinded marked this pull request as ready for review January 29, 2025 15:53
@timbrinded timbrinded requested review from a team as code owners January 29, 2025 15:53
@timbrinded timbrinded requested review from stiiifff and RomarQ January 29, 2025 15:54
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont worry its just github being weird. it was moved and edited

test/helpers/xcm.ts Outdated Show resolved Hide resolved
RomarQ
RomarQ previously approved these changes Jan 29, 2025
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a few remarks, but looks good overall 👍

@timbrinded timbrinded merged commit cb90990 into master Jan 30, 2025
37 checks passed
@timbrinded timbrinded deleted the refactor/update-types-bundle-pkg branch January 30, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants