-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 📦 Update moonbeam-types-bundle #3160
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2404 KB (no changes) 🚨 Moonriver runtime: 2400 KB (no changes) ✅ Compared to latest release (runtime-3401)Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨 Moonriver runtime: 2400 KB (+388 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master refactor/update-types-bundle-pkg +/- ##
===================================================================
Coverage 74.59% 74.59% 0.00%
Files 380 380
Lines 96035 96035
===================================================================
Hits 71632 71632
Misses 24403 24403
|
moonbeam-types-bundle/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont worry its just github being weird. it was moved and edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a few remarks, but looks good overall 👍
What does it do?
@moonbeam-foundation/types-bundle
to match our api-augment npm pkge.g.
What value does it bring to the blockchain users?
Able to call the custom RPCs properly via PolkadotJS!