Add support to generated CLIs for function arguments of arbitrary type #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests and mypy checks are completely broken. We will fix them later.
We just run a Python eval. Resolves #112
kompotkot
reviewed
Aug 9, 2023
| @@ -15,7 +15,7 @@ | |||
| "black", | |||
| "inflection", | |||
| "libcst", | |||
| "pysha3<2.0.0,>=1.0.0", | |||
| "pysha3<2.0.0,>=1.0.0; python_version < '3.6'", | |||
There was a problem hiding this comment.
Do we need to specify python_version version? Is it falling on your side? When I installed it without python_version specified in setup.py it also not exists in pip freeze
There was a problem hiding this comment.
It was failing on my side with Python 3.11, which changed the LibPython.h to not include something required by pysha3.
pysha3 is also deprecated and not used after Python 3.6 - https://github.com/tiran/pysha3
When it is used, it's a monkey patch on hashlib anyway.
So I think it's ok to keep this python_version < 3.6 constraint. Should not affect anyone's user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done the same way we handle
tuplearguments, usingtype=eval.Resolves #112
Also removed mypy type check in linting - that's been broken for a long time.
Pinned web3 version to
<6.0.0.