Register call_requests in background at metatx #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bugout-dev check
|
kellan-simiotics
approved these changes
May 7, 2024
| @@ -292,15 +299,15 @@ func (c *BugoutAPIClient) FindGroup(token, groupId string) (Group, int, error) { | |||
| var requestBodyBytes []byte | |||
| request, requestErr := http.NewRequest("GET", fmt.Sprintf("%s/group/find?group_id=%s", c.BroodBaseURL, groupId), bytes.NewBuffer(requestBodyBytes)) | |||
| if requestErr != nil { | |||
| return group, 500, requestErr | |||
| return group, 0, requestErr | |||
There was a problem hiding this comment.
Why are we sending a status code 0 on error?
There was a problem hiding this comment.
I want to pass reasonable status codes back to client, so we need to proxy it. When getting 0, it means failed on waggle side, not from other API
| } | ||
| request.Header.Add("Authorization", fmt.Sprintf("Bearer %s", token)) | ||
| request.Header.Add("Accept", "application/json") | ||
| request.Header.Add("Content-Type", "application/json") | ||
|
|
||
| response, responseErr := c.HTTPClient.Do(request) | ||
| if responseErr != nil { | ||
| return group, 500, requestErr | ||
| return group, 0, requestErr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During operations with waggle service we notices few bottlenecks and problems:
With new PR moonstream-to/api#1062 for metatx and this one for waggle next improvements:
"metatx"set in request body)Possible
"metatx"values:no_metatx- do not push call_requests to journal, sign it and return backno_check_metatx- do not check existing call_requests before push to metatxAdditional response fields:
job_entry_id- uuid of entry of jobjob_entry_url- full url to job in spire