Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garden inventory #327

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Garden inventory #327

merged 7 commits into from
Aug 22, 2023

Conversation

kellan-simiotics
Copy link
Contributor

Changes to GoFP contract to support rewards delivered to inventory.

…etStageRewards and setPathRewards signatures to avoid too many args.
Copy link
Collaborator

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellan-simiotics : Initial comments. Will review again after you implement rewards to inventory.

@kellan-simiotics kellan-simiotics marked this pull request as ready for review August 15, 2023 14:30
Copy link
Collaborator

@zomglings zomglings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Just raised an issue about possibly atomically marking persistent inventory slots as impersistent, equipping, and switching back to persistent in _equipInventoryReward.

@zomglings
Copy link
Collaborator

@bugout-dev check

  • Regenerate web3cli/GOFPFacet.py using moonworm v0.7.1

@kellan-simiotics kellan-simiotics merged commit b23e851 into main Aug 22, 2023
1 check passed
@kellan-simiotics kellan-simiotics deleted the garden-inventory branch August 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants