Finish basic implementation to know getters and setters

moosetechnology · Oct 21, 2024 · 56a1cf0 · 56a1cf0
1 parent 90ed144
commit 56a1cf0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Famix-Python-Importer-Tests/FamixPythonProject1Test.class.st b/src/Famix-Python-Importer-Tests/FamixPythonProject1Test.class.st
@@ -343,7 +343,6 @@ FamixPythonProject1Test >> testFunctionInAPackage [
 FamixPythonProject1Test >> testGetterAndSetter [
 
 	| class getter setter |
-	self skip. "For now I see that instance variables are not well managed so it make it impossible to maager getters and setters properly. Let's finish this later"
 	self denyEmpty: self model allMethods.
 
 	class := self classNamed: 'Person'.

diff --git a/src/Famix-Python-Importer/FamixPythonImporterVisitor.class.st b/src/Famix-Python-Importer/FamixPythonImporterVisitor.class.st
@@ -175,6 +175,14 @@ FamixPythonImporterVisitor >> createMethod: aMethodNode [
 			foundAction: [ :entity :currentEntity | method beGetter ]
 			ifNone: [ "We do nothing" ] ].
 
+	(aMethodNode name beginsWith: 'set_') ifTrue: [
+		self
+			resolve: ((SRIdentifierWithNode identifier: (aMethodNode name withoutPrefix: 'set_'))
+					 expectedKind: FamixPythonAttribute;
+					 yourself)
+			foundAction: [ :entity :currentEntity | method beSetter ]
+			ifNone: [ "We do nothing" ] ].
+
 	^ self setSourceAnchor: method from: aMethodNode
 ]