Merge pull request #274 from moov-io/record-errors-span

response: record errors on spans
moov-io · Dec 17, 2024 · 0aa9350 · 0aa9350
2 parents 99b5c3f + 4e88735
commit 0aa9350
Showing 1 changed file with 24 additions and 6 deletions.
diff --git a/pkg/response/file_transformer.go b/pkg/response/file_transformer.go
@@ -73,12 +73,16 @@ func (ft *FileTransfomer) Transform(ctx context.Context, file *ach.File) error {
 			if processAction != nil {
 				entry, err := ft.Entry.MorphEntry(ctx, file.Header, bh, entries[j], processAction)
 				if err != nil {
-					return fmt.Errorf("transform batch[%d] morph entry[%d] error: %v", i, j, err)
+					err = fmt.Errorf("transform batch[%d] morph entry[%d] error: %w", i, j, err)
+					span.RecordError(err)
+					return err
 				}
 
 				// Get the appropriate ach.Batch object to update
 				batch, err := outBatches.getOutBatch(processAction.Delay, entry.Category, file.Header, *file.Batches[i].GetHeader(), i)
 				if err != nil {
+					err = fmt.Errorf("transform batch[%d] morph entry[%d] getOutBatch error: %w", i, j, err)
+					span.RecordError(err)
 					return err
 				}
 
@@ -91,6 +95,8 @@ func (ft *FileTransfomer) Transform(ctx context.Context, file *ach.File) error {
 					// Get the ach.File object corresponding to this delay to write to.
 					// We don't use this ach.File yet, but it needs to be initialized for later.
 					if _, err = outFiles.getOutFile(processAction.Delay, file, ft.ValidateOpts); err != nil {
+						err = fmt.Errorf("transform batch[%d] morph entry[%d] getOutFile (delay) error: %w", i, j, err)
+						span.RecordError(err)
 						return err
 					}
 				}
@@ -107,10 +113,14 @@ func (ft *FileTransfomer) Transform(ctx context.Context, file *ach.File) error {
 					})
 
 					if err := (*batch).Create(); err != nil {
-						return fmt.Errorf("transform batch[%d] create error: %v", i, err)
+						err = fmt.Errorf("transform batch[%d] create error: %v", i, err)
+						span.RecordError(err)
+						return err
 					}
 					out, err := outFiles.getOutFile(delay, file, ft.ValidateOpts)
 					if err != nil {
+						err = fmt.Errorf("outFiles.getOutFile: %w", err)
+						span.RecordError(err)
 						return err
 					}
 					out.AddBatch(*batch)
@@ -121,7 +131,9 @@ func (ft *FileTransfomer) Transform(ctx context.Context, file *ach.File) error {
 
 	// Save off the entries as requested
 	if err := mirror.saveFiles(ctx); err != nil {
-		return fmt.Errorf("problem saving entries: %v", err)
+		err = fmt.Errorf("problem saving entries: %v", err)
+		span.RecordError(err)
+		return err
 	}
 
 	var outFileCount int
@@ -130,7 +142,9 @@ func (ft *FileTransfomer) Transform(ctx context.Context, file *ach.File) error {
 
 		if out != nil && len(out.Batches) > 0 {
 			if err := out.Create(); err != nil {
-				return fmt.Errorf("transform out create: %v", err)
+				err = fmt.Errorf("transform out create: %v", err)
+				span.RecordError(err)
+				return err
 			}
 			if err := out.Validate(); err == nil {
 				generatedFilePath := filepath.Join(ft.returnPath, generateFilename(out)) // TODO(adam): need to determine return path
@@ -140,10 +154,14 @@ func (ft *FileTransfomer) Transform(ctx context.Context, file *ach.File) error {
 				)
 
 				if err := ft.Writer.WriteFile(generatedFilePath, out, delay); err != nil {
-					return fmt.Errorf("transform write %s: %v", generatedFilePath, err)
+					err = fmt.Errorf("transform write %s: %v", generatedFilePath, err)
+					span.RecordError(err)
+					return err
 				}
 			} else {
-				return fmt.Errorf("transform validate out file: %v", err)
+				err = fmt.Errorf("transform validate out file: %v", err)
+				span.RecordError(err)
+				return err
 			}
 		}
 	}